My friend is with a girl with a lot of qualities he said he would not want in a girlfriend. Main one is smoking! Is he being desperate?
In my opinion, your friend may be desperate. This is because he is with the girl that has qualities he would not want. On the other hand, he might be blinded with looks.
Some times there are enough good qualities to overcome the bad qualities. Maybe he's hoping he can help her change the bad.