By he I'm assuming you mean God... There is nothing you can do He won't forgive you for, you sound truly sorry and that's the most important thing. I don't believe you will be punished, but keep praying :). "If we confess our sins, he is faithful and just and will forgive us our sins and purify us from all unrighteousness." 1 John 1:9 New International Version
If you have prayed for forgiveness and you are a Christian, why would God punish you? The Bible says in Matthew 11:28, "Come unto me, all ye that labour and are heavy laden, and I will give you rest." He offers rest, not punishment! I have faced the same feelings and the problem for me was that I couldn't forgive myself. That's so hard to do.
Probably not directly but if your sin has consequences He will almost certainly let you experience that in full. Like if you drink or take drugs and hurt someone and go to jail He wont save you from that. If you have sex with someone out of wedlock and a child results not only will He not make the child dissapear, He will also expect you to care for the child. If youre bullying people and get in trouble He wont keep you from being suspended. If you shoplift something He wont save you from the police. Stuff like that.
No. God would not punish you if you asked for forgiveness! But He did say when you go to enter the gates of heaven He will judge on the sins you committed if they weren't asked to be forgiven. Which is scary
Sounds like you are already punishing yourself. With this mindset, a stubbed toe would be punishment. I used to ask my son how he learned new ways to screw up. He had a need to test the limits, question authority, push the envelope. But at no time did he stop being my son because of it. I take the long view on some things: relationships trump laws in the family, and laws trump relationships in court. Try to stay out of court.
I so sorry to heard about you struggles. At Isaiah 55:7 it says, "Let the wicked man leave his way, and the harmful man his thoughts; and let him return to Jehovah, who will have mercy upon him, and to our God, for he will forgive in a large way."
It's wonderful that we receive God's loving-kindness. However, if because of our bad actions there are consequences, God will not shield us from them. At Galatians 6:7 it says, "Do not be misled: God is not one to be mocked. For whatever a man is sowing, this he will also reap."
Pray to God to help you not make the same mistake and determine what circumstances lead to that last time and take measures to correct it.