No, shotgun shells do not go bad if they are properly taken care of. If they are kept clean and dry most of the time they are fine. You would have to inspect older shells for corrosion or damage before firing them. Be sure to read the documentation on them. Some metals that are used in them corrode under different circumstances.